Skip to content

docs(ja): fix translation #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

docs(ja): fix translation #1460

merged 1 commit into from
Nov 28, 2018

Conversation

jshindo-gladd
Copy link
Contributor

  • Fixed description of fn's arguments.
  • Tweaked 1st sentence.

English:

Reactively watch fn's return value, and call the callback when the value changes. fn receives the store's state as the first argument, and getters as the second argument.

@ktsn ktsn merged commit da22a6e into vuejs:dev Nov 28, 2018
@jshindo-gladd
Copy link
Contributor Author

@ktsn Thank you!
This is my first OSS contribution.

@jshindo-gladd jshindo-gladd deleted the translation-ja branch November 28, 2018 06:23
lishihong added a commit to lishihong/vuex that referenced this pull request Jan 10, 2019
@lishihong
Revert "docs(ja): fix translation (vuejs#1460)"
bc60026 
This reverts commit da22a6e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jshindo-gladd @ktsn